Raising for invalid dtype issue #15520 #15576

petioptrv · 2017-03-05T14:06:12Z

closes #xxxx
tests added / passed
passes git diff upstream/master | flake8 --diff
whatsnew entry

jreback

first thing to always do are tests

jreback · 2017-03-05T14:44:54Z

pandas/core/generic.py

@@ -172,6 +172,12 @@ def _validate_dtype(self, dtype):
                raise NotImplementedError("compound dtypes are not implemented"
                                          "in the {0} constructor"
                                          .format(self.__class__.__name__))
+
+            # check if coerced dtype is of type object


use pandas.types.common.pandas_dtype

petioptrv · 2017-03-05T15:10:35Z

Are you saying I should raise within the pandas_dtype method?

jreback · 2017-03-05T15:22:36Z

yes pandas_dtype will raise if an invalid string is passed, but not an invalid object

In [1]: pandas.types.common.pandas_dtype(pd.Timestamp)
Out[1]: dtype('O')

In [2]: pandas.types.common.pandas_dtype('foo')
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-2-07647ef910a7> in <module>()
----> 1 pandas.types.common.pandas_dtype('foo')

/Users/jreback/pandas/pandas/types/common.py in pandas_dtype(dtype)
    491         return dtype
    492 
--> 493     return np.dtype(dtype)

TypeError: data type "foo" not understood

jreback · 2017-03-10T12:08:16Z

if you want to add some tests ping and will reopen

Update generic.py

607ae9c

jreback requested changes Mar 5, 2017

View reviewed changes

jreback closed this Mar 10, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Raising for invalid dtype issue #15520 #15576

Raising for invalid dtype issue #15520 #15576

petioptrv commented Mar 5, 2017 •

edited by jreback

Loading

jreback left a comment

jreback Mar 5, 2017

petioptrv commented Mar 5, 2017

jreback commented Mar 5, 2017

jreback commented Mar 10, 2017

Raising for invalid dtype issue #15520 #15576

Raising for invalid dtype issue #15520 #15576

Conversation

petioptrv commented Mar 5, 2017 • edited by jreback Loading

jreback left a comment

Choose a reason for hiding this comment

jreback Mar 5, 2017

Choose a reason for hiding this comment

petioptrv commented Mar 5, 2017

jreback commented Mar 5, 2017

jreback commented Mar 10, 2017

petioptrv commented Mar 5, 2017 •

edited by jreback

Loading